ci(timeseriesinsights): disable quickstart due to turned down service#15756
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the build configuration to remove the quickstart example and its corresponding integration test for the Timeseries Insights API. The change is necessary because the underlying service has been deprecated and turned down, which would otherwise lead to build failures and unnecessary CI overhead. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly disables the timeseriesinsights quickstart from the main build, which is necessary since the backing service has been turned down. My review points out that this change is likely incomplete, as it leaves behind the quickstart's source code and may not account for other CI jobs that test the quickstart. I've suggested removing the orphaned files and updating any other relevant CI configurations to fully decommission the quickstart.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15756 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 2448 2448
Lines 226254 226254
=======================================
+ Hits 210327 210333 +6
+ Misses 15927 15921 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Created #15757 to track removing the library.